Skip to content

Adding an environment to configure the default load per shard. #5899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

Adding an environment to configure the default load per shard. #5899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions quickwit/quickwit-control-plane/src/indexing_scheduler/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ mod scheduling;
use std::cmp::Ordering;
use std::fmt;
use std::num::NonZeroU32;
use std::sync::Arc;
use std::sync::{Arc, OnceLock};
use std::time::{Duration, Instant};

use fnv::{FnvHashMap, FnvHashSet};
Expand Down Expand Up @@ -177,10 +177,21 @@ fn compute_load_per_shard(shard_entries: &[&ShardEntry]) -> NonZeroU32 {
const MIN_CPU_LOAD_PER_SHARD: u32 = 50u32;
NonZeroU32::new((num_cpu_millis as u32).max(MIN_CPU_LOAD_PER_SHARD)).unwrap()
} else {
NonZeroU32::new(PIPELINE_FULL_CAPACITY.cpu_millis() / 4).unwrap()
get_default_load_per_shard()
}
}

fn get_default_load_per_shard() -> NonZeroU32 {
static DEFAULT_LOAD_PER_SHARD: OnceLock<NonZeroU32> = OnceLock::new();
*DEFAULT_LOAD_PER_SHARD.get_or_init(|| {
let default_load_per_shard = quickwit_common::get_from_env(
"QW_DEFAULT_LOAD_PER_SHARD",
Copy link
Contributor

@PSeitz-dd PSeitz-dd Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not super clear what load means here
QW_DEFAULT_CPU_PER_SHARD ?

PIPELINE_FULL_CAPACITY.cpu_millis() / 4,
);
NonZeroU32::new(default_load_per_shard).unwrap()
})
}

fn get_sources_to_schedule(model: &ControlPlaneModel) -> Vec<SourceToSchedule> {
let mut sources = Vec::new();

Expand Down