Simplifying serve function #5902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, there is no need to parse TLS config upon the reception of every connections.
fulmicoton
commented
Sep 16, 2025
|
|
||
| loop { | ||
| tokio::select! { | ||
| conn = tcp_listener.accept() => { |
Collaborator
Author
There was a problem hiding this comment.
this is not a connection.
fulmicoton
commented
Sep 16, 2025
| tokio::select! { | ||
| conn = tcp_listener.accept() => { | ||
| let (stream, _remote_addr) = match conn { | ||
| Ok(conn) => conn, |
Collaborator
Author
There was a problem hiding this comment.
careful with variable shadowing
fulmicoton
commented
Sep 16, 2025
| continue; | ||
| }; | ||
|
|
||
| let conn = server.serve_connection_with_upgrades(TokioIo::new(either_stream), service.clone()); |
fulmicoton
commented
Sep 16, 2025
| }; | ||
|
|
||
| let conn = server.serve_connection_with_upgrades(TokioIo::new(either_stream), service.clone()); | ||
| let conn = graceful.watch(conn.into_owned()); |
|
|
||
| let either_stream = | ||
| if let Some(tls_config) = &quickwit_services.node_config.rest_config.tls { | ||
| let rustls_config = tls::make_rustls_config(tls_config)?; |
Collaborator
There was a problem hiding this comment.
parsing tls config on every connection could be catastrohic. We don't know what code is running there.
Abdul-Andha
approved these changes
Sep 16, 2025
fulmicoton-dd
added a commit
that referenced
this pull request
Sep 23, 2025
In particular, there is no need to parse TLS config upon the reception of every connections. Co-authored-by: fulmicoton <paul.masurel@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, there is no need to parse TLS config upon the reception of every connections.