handle fast field search #5906
Merged
handle fast field search #5906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSeitz-dd
force-pushed
the
prefetch_fast_field
branch
from
f573636 to
4fe452f
Compare
trinity-1686a
approved these changes
Sep 17, 2025
Contributor
trinity-1686a
left a comment
trinity-1686a
left a comment
There was a problem hiding this comment.
some nits, lgtm overall
Comment on lines
+13
to
+15
| query: "text_fast:fast_text_value_dashes" | ||
| expected: | ||
| num_hits: 0 |
Contributor
There was a problem hiding this comment.
can you add a piece of doc somewhere that when we end up using the fastfield for term queries, it behave like if indexed with the raw tokenizer?
Contributor
Author
There was a problem hiding this comment.
I opened an issue for it
| impl<'a, 'f> QueryAstVisitor<'a> for TermSearchOnColumnar<'f> { | ||
| type Err = Infallible; | ||
|
|
||
| fn visit_term_set(&mut self, term_set_query: &'a TermSetQuery) -> Result<(), Infallible> { |
Contributor
There was a problem hiding this comment.
is there a test covering TermSetQuery on fastfield?
PSeitz-dd
force-pushed
the
prefetch_fast_field
branch
from
3fff4b1 to
3c73a27
Compare
fulmicoton-dd
pushed a commit
that referenced
this pull request
Sep 23, 2025
* handle fast field search * add term set query tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warm up fast fields that are searched and not indexed
add fast field search test