Fix azure multipart upload data corruption #5919
Merged
+41
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrijeet
force-pushed
the
shrijeet/azure-multi-part-bug-take2
branch
3 times, most recently
from
94b4d85 to
f034ae5
Compare
Collaborator
Author
|
|
shrijeet
force-pushed
the
shrijeet/azure-multi-part-bug-take2
branch
from
f034ae5 to
0e2d1af
Compare
guilload
reviewed
Sep 29, 2025
Member
guilload
left a comment
guilload
left a comment
There was a problem hiding this comment.
The fix looks good. I left some minor comments.
shrijeet
force-pushed
the
shrijeet/azure-multi-part-bug-take2
branch
2 times, most recently
from
0802ea2 to
ec54eff
Compare
Blocks were added to BlockList in completion order rather than sequential order, causing data corruption. Zero pad block IDs and sort before committing to ensure correct blob reconstruction. Also improve the existing test that was only checking file, the test would fail on main if integrity check was turned on. This PR passes the unit test, also has been runnin in for last two days in production without data corruption, prior to this PR - split was getting corrupted every 45 minutes.
shrijeet
force-pushed
the
shrijeet/azure-multi-part-bug-take2
branch
from
ec54eff to
c71bda2
Compare
guilload
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Blocks were added to BlockList in completion order rather than sequential order, causing data corruption. Zero pad block IDs and sort before committing to ensure correct blob reconstruction.
Also improve the existing test that was only checking file, the test would fail on main if integrity check was turned on.
How was this PR tested?
This PR passes the unit test, also has been runnin in for last two days in production without data corruption, prior to this PR - split was getting corrupted every 45 minutes.