Skip to content

don't apply congestion penalty for lost ack-only packets #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianswett merged 1 commit into from
Mar 18, 2018
Merged

don't apply congestion penalty for lost ack-only packets #1223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions draft-ietf-quic-recovery.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,19 +838,18 @@ DetectLostPackets(largest_acked):
foreach (unacked < largest_acked.packet_number):
time_since_sent = now() - unacked.time_sent
delta = largest_acked.packet_number - unacked.packet_number
if (time_since_sent > delay_until_lost):
lost_packets.insert(unacked)
else if (delta > reordering_threshold)
lost_packets.insert(unacked)
if (time_since_sent > delay_until_lost ||
delta > reordering_threshold):
sent_packets.remove(unacked.packet_number)
if (!unacked.is_ack_only):
lost_packets.insert(unacked)
else if (loss_time == 0 && delay_until_lost != infinite):
loss_time = now() + delay_until_lost - time_since_sent

// Inform the congestion controller of lost packets and
// lets it decide whether to retransmit immediately.
if (!lost_packets.empty())
if (!lost_packets.empty()):
OnPacketsLost(lost_packets)
foreach (packet in lost_packets)
sent_packets.remove(packet.packet_number)
~~~

## Discussion
Expand Down