Skip to content

Conversation

McSim85
Copy link

@McSim85 McSim85 commented Apr 7, 2025

This PR

  1. removes entrypoint.sh.
    Drone CI overrides entrypoint.sh if the pipeline has commands: defined.
    (c) https://docs.drone.io/pipeline/docker/syntax/steps/
    which says

The commands are executed inside the root directory of your git repository. The root of your git repository, also called the workspace, is shared by all steps in your pipeline. This allows file artifacts to persist between steps. NB “commands” overrides the docker entrypoint.

  1. modifies ANSIBLE_STRATEGY_PLUGINS
    Because we cannot use entrypoint with Drone, the only way to define ANSIBLE_STRATEGY_PLUGINS is to hardcode the path into Dockerfile and also, I have added an if statement, that will verify if path changed or not during the build process.

  2. Adds final apt-get update
    We need apt-get update for backward compatibility with Drone CI tasks that run apt-get install X without apt-get update.

@McSim85 McSim85 requested a review from a team as a code owner April 7, 2025 19:09
@McSim85 McSim85 requested a review from a team April 8, 2025 10:52
@McSim85 McSim85 merged commit f228202 into main Apr 8, 2025
2 checks passed
@McSim85 McSim85 deleted the TEC-1680/more-fixes2 branch April 8, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants