Skip to content

Conversation

@vignesh-v3
Copy link

currently we use sjoshi/ansible-core image in almost all of our role-* repositories, this PR would start to push images in the GHCR

we now have the images pushed to GHCR

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #89752: Create working github action for Ansible Docker image.

@vignesh-v3 vignesh-v3 marked this pull request as draft January 31, 2024 06:38
@vignesh-v3 vignesh-v3 marked this pull request as ready for review January 31, 2024 07:28
@vignesh-v3 vignesh-v3 requested review from a team and sjoshi10 January 31, 2024 07:31
Copy link

@McSim85 McSim85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so awesome, that you started to work on this @vignesh-v3
Overall the recommendation - configure dependabot properly, so it will automatically submit new versions.

@vignesh-v3 vignesh-v3 requested a review from McSim85 February 1, 2024 15:12
Copy link
Collaborator

@sjoshi10 sjoshi10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vignesh-v3
Copy link
Author

This is so awesome, that you started to work on this @vignesh-v3 Overall the recommendation - configure dependabot properly, so it will automatically submit new versions.

@McSim85 i pushed a minor pip related change to dependabot.yml, please let me know if we're good.

cc: @sjoshi10

@vignesh-v3 vignesh-v3 requested a review from sjoshi10 February 8, 2024 07:06
Copy link

@McSim85 McSim85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guys, I am approving this PR, because the goal of the PR - moving from Saurab account to quicknode.
But, I think, we should revisit this role later to make

  • dependabot handle all version upgrades
  • remove unused OS like almalinux8, alpine
  • RUN instructions can be also revisited and improve multiple apt commands

@vignesh-v3
Copy link
Author

going to merge this, we can open a separate story for the above items.
cc: @sjoshi10

@vignesh-v3 vignesh-v3 merged commit f7a9fa6 into main Feb 10, 2024
@vignesh-v3 vignesh-v3 deleted the sc-89752 branch February 10, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants