Skip to content

[Task/33358] - additions to 'using Quix Streams' topic #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 29, 2023
Merged

[Task/33358] - additions to 'using Quix Streams' topic #69

merged 8 commits into from
Mar 29, 2023

Conversation

@tbedford
Copy link
Contributor

@tbedford tbedford commented Mar 20, 2023 •
edited
Loading

Description

  • Changes nav bar entry to 'Using Quix Streams'
  • Adds paragraph on cross-stream aggregation
  • Adds warnings for code that demonstrates potential pitfalls

Review

Page to review

@tbedford tbedford self-assigned this Mar 20, 2023
@tbedford tbedford marked this pull request as ready for review March 20, 2023 16:15
@tbedford tbedford requested a review from tomas-quix March 20, 2023 16:15
@tbedford tbedford changed the title [Task/33358] - add tomas feedback [Task/33358] - additions to 'using Quix Streams' topic Mar 21, 2023
@tbedford
Copy link
Contributor Author

@tomas-quix - would you be able to confirm I made all the changes you required please? Thanks!

tomas-quix
tomas-quix reviewed Mar 22, 2023
View reviewed changes
tomas-quix
tomas-quix reviewed Mar 22, 2023
View reviewed changes
@tbedford tbedford requested a review from JotaBlanco March 24, 2023 11:19
JotaBlanco
JotaBlanco reviewed Mar 28, 2023
View reviewed changes
Copy link

@JotaBlanco JotaBlanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really liked it. I've actually learn the flush method once for all reading this! I've added some suggestions though

@tbedford tbedford requested a review from JotaBlanco March 29, 2023 10:10
JotaBlanco
JotaBlanco approved these changes Mar 29, 2023
View reviewed changes
Copy link

@JotaBlanco JotaBlanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consumer groups are much better now.

@tbedford tbedford merged commit fd0a5ac into main Mar 29, 2023
@tbedford tbedford deleted the task/33358-add-tomas-feedback branch March 29, 2023 10:46
tim-quix pushed a commit that referenced this pull request Nov 14, 2023
@SteveRosam
Merge pull request #69 from quixio/task/32361-connector-readmes
4fc1c15 
#32361 Connector readmes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomas-quix tomas-quix tomas-quix left review comments

+1 more reviewer

@JotaBlanco JotaBlanco JotaBlanco approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tbedford tbedford

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tbedford @JotaBlanco @tomas-quix