-
Couldn't load subscription status.
- Fork 91
Unit tests fixes and log improvements #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
peter-quix
commented
Mar 30, 2023
- Fix unit tests in python and c# to consistently pass. (including a fix for Daylight saving time or other than UTC breaks unit tests #76)
- Disable unit tests for now that are expected to fail in python
- Log a warning instead of throwing an exception when subscribing multiple times as this is not a catastrophic issue, but one the user should not perform unnecessarily as a hint at a code issue
- Improved the log checker for InteropGenerator to give partial results rather than crash
- When TimeseriesData (not the Raw variant, which is used for pandas in python) is used with multiple data types, it threw an exception. Now it will log a warning and use the type already in the dictionary instead.
- InteropException to always include the stack trace in message
- Do not convert to TimeseriesData when not necessary - Move ParameterValueType to the class owning collection of values
harisbotic
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.