Proposal: combine wave correctness and convergence test pairs into a single binary #1916
Closed
AstroKriel
started this conversation in
Ideas
Replies: 1 comment
-
|
Resolved by #1978 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
There currently exist several wave test problems where both a correctness test (
FastWave,SlowWave,AlfvenWaveLinear,HydroWave) and a Richardson convergence test (FastWaveConvergence,SlowWaveConvergence, etc.) exist, each reimplementing the same IC logic. This inflates the test count and upkeep cost, which came up in the review of #1910.Proposed design
Consolidate each pair into the
...Convergencebinary. The binary reads mode flags and parameters from a[setup]table:Mode flags (at least one must be true):
setup.run_convergence(default:true): runs the Richardson sweepsetup.run_sim(default:false): runs a single fixed-resolution correctness check at the TOML-specified resolution and stop timeConvergence parameters (
run_convergence = true):setup.nx_start— starting resolutionsetup.nx_max— ending resolutionsetup.machine_precision_target— 0 disables early exit and runs all levels tonx_maxsetup.refine_n_dims(default: 1) — dimensions to refine; see Proposal: extend Richardson convergence harness to support N-dimensional refinement #1958Correctness parameters (
run_sim = true):setup.error_tol— L1 error tolerance for pass/failWave parameters (MHD problems only):
setup.angle_between_k_b0(default: 0.0)setup.num_modes_xWith default TOML files unchanged, CTest behaviour is identical to today.
Affected binaries
FastWaveConvergenceFastWaveSlowWaveConvergenceSlowWaveAlfvenWaveLinearConvergenceAlfvenWaveLinearHydroWaveConvergenceHydroWaveEntropyWaveConvergenceMotivation
setup.*parameter surface across all wave convergence tests (currently inconsistent:HydroWaveConvergenceis fully hardcoded;EntropyWaveConvergenceis missingnx_start,nx_max,machine_precision_target).Deferred
setup.num_modes_y,setup.num_modes_z, and 2D/3D TOML configs: pending the Richardson N-dimensional refinement extension (Proposal: extend Richardson convergence harness to support N-dimensional refinement #1958).mhd.resistivitysupport inrun_simmode beyondAlfvenWaveLinear: deferred.Relation to other proposals
Depends on the Richardson N-dimensional refinement extension (#1958).
Beta Was this translation helpful? Give feedback.
All reactions