Skip to content

RoomListModel: add unread and highlight indicators to tags #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2021
Merged

RoomListModel: add unread and highlight indicators to tags #747

merged 2 commits into from
Feb 7, 2021

Conversation

@krkk
Copy link
Contributor

@krkk krkk commented Feb 7, 2021

preview

KitsuneRal
KitsuneRal reviewed Feb 7, 2021
View reviewed changes
Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I like the highlighting part definitely but I'm not sure about the number of notifications - would it not be confused with the number of rooms in the group?

@KitsuneRal KitsuneRal added the enhancement A feature or change request for Quaternion label Feb 7, 2021
KitsuneRal
KitsuneRal approved these changes Feb 7, 2021
View reviewed changes
Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scratch the previous review - we already have the number of rooms there, and a small confusion between the number of rooms with notifications and the number of notifications is probably fine.

@KitsuneRal KitsuneRal merged commit c77a77a into quotient-im:master Feb 7, 2021
@krkk krkk deleted the tag-unreads branch February 7, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KitsuneRal KitsuneRal KitsuneRal approved these changes

Assignees

No one assigned

Labels

enhancement A feature or change request for Quaternion

Projects

Quaternion 1
Status: Version 0.0.95 - Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@krkk @KitsuneRal