-
Notifications
You must be signed in to change notification settings - Fork 9
📘 Docs: Add auto-translate warning + OpenAPI fixes for audio endpoints (document segments=true; correct List Surah Recitation schema) #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in random verse endpoint Added missing documentation for existing query parameters supported by the random verse endpoint: - chapter_number - page_number - juz_number - hizb_number - rub_el_hizb_number - ruku_number - manzil_number These parameters were already supported in the API but not reflected in the documentation. This update ensures developers are aware of all available filtering options when using the endpoint.
/tafsirs/{resource_id}/by_ayah/{ayah_key} Fixed the incorrect response schema shown for the /tafsirs/{resource_id}/by_ayah/{ayah_key} endpoint in the docs. The autogenerated version via <ApiTabs> was causing runtime crashes due to unresolved OpenAPI store references. Since that approach wasn't working despite correct infoPath and operationId setup, we manually wrote the MDX documentation using standard Docusaurus components. Tested locally – page now renders successfully and reflects the accurate response structure.
list-ayah-tafsirs and regenerate MDX Updated the OpenAPI schema (v4.json) for the /tafsirs/{resource_id}/by_ayah/{ayah_key} endpoint to ensure the response structure reflects the actual API output. The previous crash with <ApiTabs> was due to incorrect or incomplete schema context. After fixing the schema, we ran: - yarn clean-all - yarn gen-all - yarn start The generated docs now render correctly and reflect the accurate response, eliminating the need for manual overrides.
Fix additional v4 typos
…haf--in-v4.json Fix Mushaf typo
…aceholders-in-v4.json Fix unrendered model placeholders
tokens with actual endpoints
…-tokens-in-v4.json Fix placeholder endpoints
…in-get-todays-plan-api Fix mushafId param docs
…fields-and-word_fields Add field reference documentation and links
…g-other-endpoints docs: link resource references
…ation-for-docusaurus Add JavaScript SDK docs
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…in v4.json (param, schema, and examples)
…mestamps; correct schema & examples)
osamasayed
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR now includes two documentation updates:
Auto-translate warning (content docs)
OpenAPI spec corrections (used by Docusaurus)
File:
v4.json
(OpenAPI 3.x). No MDX changes; docs will be regenerated from this file.Endpoint: Chapter Reciter Audio File (
/docs/content_apis_versioned/chapter-reciter-audio-file
)segments: boolean
(defaultfalse
).200
response schema to includetimestamps[]
with optionalsegments
whensegments=true
.timestamps
+segments
).SegmentTriplet
,VerseTimestamp
,AudioFile
,ChapterReciterAudioFileResponse
).Endpoint: List Surah Recitation (
/docs/content_apis_versioned/list-surah-recitation
)Remove any mention of
segments
(param or field).Ensure response is:
Replace incorrect schema/examples that showed
timestamps/segments
with the correct ones above.Keep/standardize the
Pagination
schema.Why
segments=true
behavior or showed fields that the API doesn’t return for List Surah Recitation.Backward compatibility
segments
is optional; default behavior is unchanged.segments
).How to review
Review
v4.json
diff only.Rebuild docs from
v4.json
and verify:segments
param.{ verse_key, url }
pluspagination
(notimestamps/segments
).Release notes
segments=true
for Chapter Reciter Audio File; fix List Surah Recitation schema/examples to removesegments
.