Skip to content

Conversation

@shumpohl
Copy link
Member

@shumpohl shumpohl commented Nov 8, 2018

A draft for an abstract pulse template.

The user can declare an abstract pulse template with certain properties like defined_channels and parameter_names. If the property getter of a declared property is called, the property is marked as frozen. Calling the getter of a non-declared property raises an exception.

To instantiate an abstract pulse template it has to be linked to a "real" pulse template via link_to. All frozen properties need to be exactly identical to the properties of the linked pulse template. This ensures that calling the getter of a property always yields the same result for the same object.

@lumip thoughts?

@shumpohl shumpohl requested a review from lumip November 8, 2018 11:22
- Make link target serialization a mutable setting
- Forward getattr calls
- Forward abstract methods explicitly
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1599

  • 59 of 71 (83.1%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 93.357%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qupulse/pulses/abstract_pulse_template.py 59 71 83.1%
Files with Coverage Reduction New Missed Lines %
qupulse/utils/types.py 3 100.0%
Totals Coverage Status
Change from base Build 1589: -0.2%
Covered Lines: 4682
Relevant Lines: 4947

💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 13, 2018

Pull Request Test Coverage Report for Build 1659

  • 78 of 78 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 93.567%

Totals Coverage Status
Change from base Build 1657: 0.09%
Covered Lines: 4717
Relevant Lines: 4974

💛 - Coveralls

@shumpohl shumpohl changed the title [WIP] Draft for an abstract pulse template. Abstract pulse template. Feb 25, 2019
@shumpohl shumpohl merged commit 3fd329f into master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants