Driver abstraction (rebased) #509
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import base classes from old_base
Import base classes from old_base
Refactoring of class/function names Modification of import statements for hardware.awgs.old_base
Actually no unit tests, yet, but a first example of how to use the base drivers
…nfusion with old_base.AWG
* Features are now implemented as a subclass * Error handling when adding/getting features * Added some first features in features.py. This file will contain general features, which can be subclassed for specific instruments
…keep py3.5-compatibility
…keep py3.5-compatibility
Pull Request Test Coverage Report for Build 2042
💛 - Coveralls |
|
@terrorfisch, can we merge this pull request and then use a new one for the specific drivers? Or do you want us to do everything in this pull request? |
I plan to do a the 0.5 very soon and I do not think this feature will make it, so I think we should collect all changes and merge them at once. |
lankes-fzj
force-pushed
the
feat/awg-abstraction/rebased
branch
from
49f8bb9 to
300ac7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.