Skip to content

Milestone/release 0.5 #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 2, 2020
Merged

Milestone/release 0.5 #526

merged 6 commits into from
Apr 2, 2020

Conversation

@shumpohl
Copy link
Member

@shumpohl shumpohl commented Apr 2, 2020

No description provided.

@shumpohl shumpohl closed this Apr 2, 2020
@shumpohl shumpohl reopened this Apr 2, 2020
@shumpohl
Copy link
Member Author

shumpohl commented Apr 2, 2020

This is quite a mess. Reverting a revert convolutes everything

@coveralls
Copy link

coveralls commented Apr 2, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 2136

  • 114 of 314 (36.31%) changed or added relevant lines in 8 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.4%) to 85.027%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qupulse/_program/seqc.py 26 31 83.87%
qupulse/hardware/awgs/zihdawg.py 71 266 26.69%
Files with Coverage Reduction New Missed Lines %
qupulse/hardware/awgs/zihdawg.py 2 35.88%
Totals Coverage Status
Change from base Build 2131: -1.4%
Covered Lines: 6241
Relevant Lines: 7220
💛 - Coveralls

@shumpohl
Copy link
Member Author

shumpohl commented Apr 2, 2020

Tests fail because numpy.testing.assert_equal struggles with unittest.mock.Mock() in some python versions

@shumpohl shumpohl merged commit c7d932d into master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shumpohl @coveralls