Skip to content

Use to internal to convert to mpq #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Use to internal to convert to mpq #541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion qupulse/utils/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ def from_float(cls, value: float, absolute_error: typing.Optional[float] = None)
elif absolute_error > 1:
raise ValueError('absolute_error needs to be <= 1')
else:
return cls(qupulse_numeric.approximate_double(value, absolute_error, fraction_type=cls._InternalType))
return cls(qupulse_numeric.approximate_double(value, absolute_error, fraction_type=cls._to_internal))

@classmethod
def from_fraction(cls, numerator: int, denominator: int) -> 'TimeType':
Expand Down
2 changes: 2 additions & 0 deletions tests/utils/time_type_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ def assert_fraction_time_from_float_with_precision_works(self, time_type):
fractions.Fraction(1))
self.assertEqual(time_type.from_float(2.50000000000008, absolute_error=1e-10),
time_type.from_fraction(5, 2))
self.assertEqual(time_type.from_float(9926.666666667, absolute_error=1e-9),
time_type.from_fraction(29780, 3))

def test_fraction_time_from_float_with_precision(self):
self.assert_fraction_time_from_float_with_precision_works(qutypes.TimeType)
Expand Down