Add to_single_waveform property to PulseTemplate #889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 6 files 6 suites 7m 35s ⏱️ Results for commit 3fea47d. ♻️ This comment has been updated with latest results. |
|
@Nomos11 To you think this is reasonable? |
|
@Nomos11 plz merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
to_single_waveformargument toPulseTemplatewhich makes it translate itself into a single waveform on program creation.Furthermore these pulse templates for ward the kwarg:
SequencePTRepetitionPTForLoopPT.MappingPTCloses #578
Enables #882
Documentation is moved to #894