Skip to content

Remove AtomicPulseTemplate.atomicity #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025
Merged

Remove AtomicPulseTemplate.atomicity #911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions qupulse/pulses/pulse_template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,11 +685,6 @@ def with_parallel_atomic(self, *parallel: 'AtomicPulseTemplate') -> 'AtomicPulse
else:
return self

@property
def atomicity(self) -> bool:
warnings.warn("Deprecated since neither maintained nor properly designed.", category=DeprecationWarning)
return True

def _is_atomic(self) -> bool:
return True

Expand Down
1 change: 0 additions & 1 deletion tests/hardware/tabor_clock_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ def get_pulse():
marker_on = FPT('1', 'tau', channel='trigger')

multi = MPT([sine, marker_on], {'tau', 'U'})
multi.atomicity = True

assert sine.defined_channels == {'out'}
assert multi.defined_channels == {'out', 'trigger'}
Expand Down
Loading