fix: Add adoptedStyleSheets.get() to patched document in worker.#674
Merged
gioboa merged 2 commits intoQwikDev:mainfrom May 20, 2025
Merged
fix: Add adoptedStyleSheets.get() to patched document in worker.#674gioboa merged 2 commits intoQwikDev:mainfrom
document in worker.#674gioboa merged 2 commits intoQwikDev:mainfrom
Conversation
🦋 Changeset detectedLatest commit: d8a7096 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
leeroybrun
changed the title
document in worker. Fixes #666document in worker.
gioboa
approved these changes
May 19, 2025
Member
gioboa
left a comment
gioboa
left a comment
There was a problem hiding this comment.
Thanks @leeroybrun it looks great to me 👏
gioboa
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Clarity is trying to access
document.adoptedStyleSheetsin the worker, which returns an array of strings:#666
Use cases and why
Checklist:
I have checked the http://localhost:4000/tests/integrations/clarity/ test before and after the fix.
I can confirm that before the fix, the error was present (after some time):
And after the fix, Clarity seems to work and no error was present (even after some time spent on the page):
