Implement limited callable API for vroom #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisVaughan
force-pushed
the
feature/clock-api
branch
from
18a6bff to
85a3b8e
Compare
It seems like the forward declaration of `class time_zone` in `date/tz.h` is enough to allow us to use it as a return value and an argument
vroom will possibly call this in parallel, and will catch any runtime errors. However, you cannot throw a cpp11 error, or allocate any R memory, while in a thread.
This way the client can choose exactly how to handle nonexistent and ambiguous times, and we don't have to return a custom struct for nonexistent times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For tidyverse/vroom#322