Fix condition expectations in prevision of testthat breaking change

[lionel-]

We are planning a breaking change to the condition expectations in testthat release (see NEWS item in r-lib/testthat#1401). This PR implements a preventive fix that works with and without the breaking change.

There is no hurry to get this fix on CRAN since we are skipping one released version of testthat before going through with the change.

[DavisVaughan]

Thanks!

[hadley]

We're planning on releasing to CRAN soon, so I'd really appreciate it if you could do a release so we avoid breaking a CRAN check for your package 😄

[DavisVaughan]

Hmm this was included in 0.3.1 which was sent to CRAN awhile back. Is there a different issue?

Should I just run the clock checks with dev testthat?

[hadley]

Yeah, there must be a new issue. I saw this:

══ Failed tests ════════════════════════════════════════════════════════════════
── Failure (test-zoned-time.R:399:3): %z must parse correctly if included ──────
expect_warning(...) (`actual`) not identical to `expect` (`expected`).

`actual` is length 2
`expected` is length 1

    class(actual)                  | class(expected)       
[1] "clock_warning_parse_failures" - "clock_zoned_time" [1]
[2] "clock_warning"                - "clock_rcrd"       [2]
[3] "warning"                      - "vctrs_rcrd"       [3]
[4] "condition"                    - "vctrs_vctr"       [4]

`names(actual)`:   "message" "trace"       
`names(expected)`: "ticks"   "ticks_of_day"

`attr(actual, 'precision')` is absent
`attr(expected, 'precision')` is an integer vector (7)

`attr(actual, 'zone')` is absent
`attr(expected, 'zone')` is a character vector ('America/New_York')

`actual$message` is a character vector ('Failed to parse 1 string at location 1. Returning `NA` at that location.')
`expected$message` is absent

`actual$trace` is an S3 object of class <rlang_trace>, a list
`expected$trace` is absent

`actual$ticks` is absent
`expected$ticks` is an integer vector (NA)

`actual$ticks_of_day` is absent
`expected$ticks_of_day` is an integer vector (NA)

[ FAIL 1 | WARN 0 | SKIP 221 | PASS 976 ]
Error: Test failures
Execution halted