Skip to content

Conversation

@vspinu
Copy link
Contributor

@vspinu vspinu commented Jun 6, 2021

Modified base names break navigation to the original file location on errors (in my case emacs/ESS). Modifying only the shared lib path at the end would have the same effect of registering dyn lib with a new name.

@vspinu vspinu force-pushed the source-no-name-change branch from 57309f1 to 455da44 Compare June 6, 2021 21:19
@jimhester
Copy link
Member

I think the shared library passed to dyn.load() needs to have a unique name on Windows or else it is not loaded by R.

I believe this proposed change would break #143

@vspinu
Copy link
Contributor Author

vspinu commented Jun 9, 2021

In my PR dll names are changed, the file name is not. So dyn.load() still receives different dll each time.

I might not have been very clear, the errors I am referring to are compiler errors which refer to the temporary cpp files. What happens to the dll latter does not matter.

@jimhester
Copy link
Member

Oh I see what you are doing now, didn't quite grasp it the first time I read your proposed changes.

Thanks for the clarification, I think it looks OK.

@jimhester jimhester merged commit 4ef13b7 into r-lib:master Jun 9, 2021
@vspinu vspinu deleted the source-no-name-change branch June 13, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants