Remove legacy non-unwind protect code paths #241
Merged
+5
−169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the codebase by removing legacy code paths that supported non-unwind protect mode in Rcpp. Since Rcpp has defaulted to unwind protect since July 2022 and the package now requires Rcpp >= 1.0.10 (released in 2023), the conditional compilation and fallback code are no longer needed.
Key changes:
- Removed conditional compilation directives (
#ifdef RCPP_USING_UNWIND_PROTECT) - Removed legacy
invoke_wrapped()method and associated helper functions (invoke_c, exception handling code) - Updated minimum Rcpp version requirement from 0.12.9 to 1.0.10
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| DESCRIPTION | Updated minimum Rcpp version from 0.12.9 to 1.0.10 |
| src/later.cpp | Removed conditional compilation for callback invocation, now always uses invoke() |
| src/callback_registry.h | Removed invoke_wrapped() declaration and conditional compilation in StdFunctionCallback::invoke() |
| src/callback_registry.cpp | Removed 152 lines of legacy code including invoke_c() and invoke_wrapped() implementations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shikokuchuo
force-pushed
the
unwind-protect
branch
from
28cfadd to
0037664
Compare
shikokuchuo
force-pushed
the
unwind-protect
branch
from
0037664 to
f30b0db
Compare
schloerke
approved these changes
Nov 13, 2025
Co-authored-by: Barret Schloerke <schloerke@gmail.com>
Co-authored-by: Barret Schloerke <schloerke@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the code base as Rcpp has defaulted to using unwind protect since Jul 2022.
We now require the next major version of Rcpp after that (1.0.10) from 2023.