Skip to content

Conversation

IndrajeetPatil
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil commented May 13, 2024

Closes #1206

And also remove everything that was needed for R 3.2.

Script used to delete files:

tree_files_to_delete <-
  fs::dir_ls(
    path = ".",
    glob = "*.R|*.Rprofile|*.Rmd|*.Rmarkdown|*.Rnw|*.Qmd",
    invert = TRUE,
    type = "file",
    recurse = TRUE
  ) |>
  stringr::str_subset("_tree") |>
  purrr::map_chr(fs::path_abs)

stopifnot(all(fs::file_exists(tree_files_to_delete)))

fs::file_delete(tree_files_to_delete)

closes #1206

And also remove everything that was needed for R 3.2.

This comment was marked as outdated.

revdep/
!revdep/*.md
!revdep/problems.md
tests/testthat/*/*-in_tree
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check that this is correct ignore directive.

Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 4f78252 is merged into main:

  • ✔️cache_applying: 161ms -> 161ms [-2.78%, +2.16%]
  • ✔️cache_recording: 526ms -> 527ms [-0.74%, +1.24%]
  • ✔️without_cache: 987ms -> 988ms [-0.38%, +0.58%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@IndrajeetPatil IndrajeetPatil merged commit 1088ede into main May 19, 2024
@IndrajeetPatil IndrajeetPatil deleted the f1206-no-code-tree-structure branch May 19, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reconsider storing code tree structure for tests by default

2 participants