Correctly test inputs in expect_setequal() (#2244)

Author: hadley

R/expect-setequal.R

@@ -28,8 +28,8 @@ expect_setequal <- function(object, expected) {
   act <- quasi_label(enquo(object))
   exp <- quasi_label(enquo(expected))
 
-  check_vector(object)
-  check_vector(expected)
+  check_vector(act$val, error_arg = "object")
+  check_vector(exp$val, error_arg = "expected")
   if (!is.null(names(act$val)) && !is.null(names(exp$val))) {
     testthat_warn("expect_setequal() ignores names")
   }

tests/testthat/_snaps/expect-setequal.md

@@ -18,6 +18,16 @@
     Condition
       Error in `expect_setequal()`:
       ! `expected` must be a vector, not a primitive function.
+    Code
+      expect_setequal(!!fun, 1)
+    Condition
+      Error in `expect_setequal()`:
+      ! `object` must be a vector, not a primitive function.
+    Code
+      expect_setequal(1, !!fun)
+    Condition
+      Error in `expect_setequal()`:
+      ! `expected` must be a vector, not a primitive function.
 
 # useful message on failure
 

tests/testthat/test-expect-setequal.R

@@ -26,9 +26,12 @@ test_that("warns if both inputs are named", {
 })
 
 test_that("checks inputs", {
+  fun <- sum
   expect_snapshot(error = TRUE, {
     expect_setequal(sum, 1)
     expect_setequal(1, sum)
+    expect_setequal(!!fun, 1)
+    expect_setequal(1, !!fun)
   })
 })