Skip to content

Conversation

@hadley
Copy link
Member

@hadley hadley commented Oct 6, 2025

Fixes #2247

@claude
Copy link

claude bot commented Oct 6, 2025

Claude finished @hadley's task —— View job


Review Complete

  • Read and analyze changed files
  • Review implementation for potential bugs
  • Check test coverage and snapshots
  • Provide feedback

Issues Found

R/expectation.R:24 - check_character(failure_message) validates scalar character but should allow character vectors. The parameter documentation says failure_message is a "Message" (singular), but check_character() accepts any character vector. This inconsistency could be confusing.

The validation functions from the standalone types-check library are being used correctly and the test coverage is adequate.


@hadley hadley merged commit 6e3c1e5 into main Oct 6, 2025
13 checks passed
@hadley hadley deleted the check-expect-inputs branch October 6, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

expect() should tests its inputs

2 participants