Improve show_text()
#2257
Merged
Improve show_text()
#2257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix `lengths()` type * Handle case where we remove first line of new item * Add some tests Fixes #2249
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
gadenbuie
reviewed
Oct 9, 2025
Comment on lines
+183
to
+185
| if (first[max_lines + 1]) { | ||
| max_lines <- max_lines - 1 | ||
| } |
There was a problem hiding this comment.
I might be misreading this, but I would have expected
Suggested change
| if (first[max_lines + 1]) { | |
| max_lines <- max_lines - 1 | |
| } | |
| if (first[max_lines]) { | |
| max_lines <- max_lines - 1 | |
| } |
to avoid output like this (assuming max_lines = 2)
[1] | x
| y
[2] | ...
... and 1 more.
i.e. I was thinking this we'd prefer to show an item only if you see at least one line, e.g.
[1] | x
| y
... and 2 more.
whereas using first[max_lines + 1] gives
[1] | x
| ...
... and 2 more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lengths()typoFixes #2249