Make labels more flexible

[hadley]

@DavisVaughan could you please have a look at the specific labels, but also contemplate what you think of this design.

[claude]

Claude finished @hadley's task —— View job

---

Code Review Analysis

Todo List:

• Read and analyze changed R source files
• Review snapshot test changes
• Identify potential bugs or issues
• Provide concise feedback on design approach

Issues Found

Bug in expect_waldo_equal_() (R/expect-equality.R:154):

paste0(comp, collpase = "\n")  # typo: should be "collapse"

Potential issue in labelling approach:
The change from "names of " + act$lab to just act$lab in error messages may be less clear. Compare:

• Before: Expected names of 'x' to have the same values as names of 'y'.
• After: Expected 'x' to have the same names as 'y'.

The new approach is more concise but potentially ambiguous when the expectation is about names specifically.

Design Assessment

The refactoring improves consistency by making message templates explicit parameters rather than hardcoded strings. This makes the helper functions more flexible and reusable.

[DavisVaughan]

I think more succinct is always better if it captures the same intent, and this seems to do that well 👍