Skip to content

Conversation

@hadley
Copy link
Member

@hadley hadley commented Oct 27, 2025

Can't yet remove is_informative_error() because vctrs still registers methods for it.

Can't yet remove `is_informative_error()` because vctrs still registers methods for it.
@hadley hadley mentioned this pull request Oct 27, 2025
22 tasks
@claude
Copy link

claude bot commented Oct 27, 2025

Claude finished @hadley's task —— View job


Reviewing PR for potential bugs or issues...

Todo List

  • Read and analyze changed files
  • Check for potential bugs or issues
  • Provide review feedback

Review

The changes look clean and properly advance deprecations:

  1. expect_snapshot_file(binary): Correctly upgraded from lifecycle::deprecate_soft() to lifecycle::deprecate_warn() in R/snapshot-file.R:140. This is the expected progression for deprecation lifecycle.

  2. test_dir(wrap) removal: Properly removed the deprecated parameter and all associated code from:

    • Function signatures
    • Parameter validation logic
    • Documentation

The implementation is consistent across all affected functions (test_dir(), test_files(), test_files_serial()). Documentation updates match code changes.

LGTM - no bugs or issues identified.

@hadley hadley merged commit de6d62d into main Oct 27, 2025
14 checks passed
@hadley hadley deleted the advance-deprecations-2025-10 branch October 27, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants