Skip to content

ci: Test all R versions on branches that start with cran-#62

Merged
krlmlr merged 1 commit into
mainfrom
actions-sync-update
Jan 13, 2026
Merged

ci: Test all R versions on branches that start with cran-#62
krlmlr merged 1 commit into
mainfrom
actions-sync-update

Conversation

@krlmlr
Copy link
Copy Markdown
Member

@krlmlr krlmlr commented Jan 13, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 13, 2026 06:20
@krlmlr krlmlr merged commit 9a543f4 into main Jan 13, 2026
1 check passed
@krlmlr krlmlr deleted the actions-sync-update branch January 13, 2026 06:21
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modifies the GitHub Actions workflow to enable full R version testing for branches that start with "cran-", likely to ensure comprehensive testing before CRAN submissions.

Changes:

  • Modified the versions-matrix step condition to also run for pull requests from the same repository when the branch name starts with "cran-"
  • Simplified the rcc-full job condition to run whenever a versions matrix is generated (removing the restriction to only schedule and manual dispatch events)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

# Only run for pull requests if the base repo is different from the head repo, not for workflow_dispatch if not requested, always run for other events
if: (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.repository) && (github.event_name != 'workflow_dispatch' || inputs.versions-matrix)
# Only run for:
# - pull requests if the base repo is different from the head repo and the branch name does not start with "cran-"
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is misleading. It states "pull requests if the base repo is different from the head repo and the branch name does not start with 'cran-'" but the logic actually uses OR not AND. The condition will run for pull requests when EITHER the repos are different OR the branch starts with 'cran-'. A more accurate comment would be: "pull requests if the base repo is different from the head repo OR the branch name starts with 'cran-'"

Suggested change
# - pull requests if the base repo is different from the head repo and the branch name does not start with "cran-"
# - pull requests if the base repo is different from the head repo or the branch name starts with "cran-"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants