-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation issue with Fedora: missing -fPIC flag #1369
Comments
I just had the same issue. It is caused by commit a37c5a0. Reverting this commit fixes the compilation on Fedora, so I am not sure whether adding the |
Looks like CRAN fedora didn't have an issue with it; please discuss with @zerothi and #1291 how to proceed in a way that doesn't break my next submission to CRAN. |
Perhaps moving LDFLAGS to the end of the line is the better approach. Could you show your LDFLAGS? |
Here is the result on my computer
|
Same here on the current Fedora beta, i.e. on Fedora 32. |
Could you try and move a37c5a0 LDFLAGS to the end of the line and try again |
Doesn't seem to work for me... Same error as posted above. |
My I can reproduce the problem with the Fedora R rpm. Changing the position does not help. Probably must trap the As things stand, sf from CRAN (0.9-2) cannot be installed using the Fedora R rpm. The rpm Where in |
LDFLAGS is detected here The problem is that Fedora sets Seems like a recurring problem for Fedora... :( I see no other way than to revert, unless you want to detect specs in configure... :( |
Yes, reverting seems sensible, given the immediate reaction. Shame there is no test framework for this, maybe a Fedora R rpm user on this issue should volunteer to test pre-release candidates. |
So there is consensus to revert a37c5a0 ? |
Sadly, yes... :( |
For those stuck until the reversion is published, and are using the R rpm, it looks as though setting |
I could certainly do this. How do I know when you are preparing a new release for CRAN? |
I think I did this in 24814bd ? |
Sure, you fixed this issue. I was just offering in general to test your pre-release candidates on Fedora, as Roger proposed, in case there's any need for that. |
@hriebl Thanks! All testing before submissions go to CRAN is very helpful, but we don't have a mechanism (I think) to say when an RC (release candidate) is ready to be checked. The easiest way is to download an RC tarball, and run R CMD check at the command line, and report back as good to go, minor issues, or show-stopper. Github tries to internalise this with CI, but it is difficult to cover all angles. If we went to (r-spatial/discuss#37) OSGeo-style PSC RC handling, we could put a system in place for staged RC tarball publication prior to CRAN submission, but we are not there yet. |
Thank you, @rsbivand! How about, for the time being, you set up a mailing list for RC testers and ask them to check whether the current master branch still compiles on their systems a couple of days before submitting to CRAN? |
fixes r-spatial#1369 undoes/reverts r-spatial#1291
Not sure if this is the right issue. Definitely the same as #1379 I can't get the sf package to install on Fedora 32. Keep getting the error: checking PROJ: checking whether PROJ and sqlite3 are available for linking:... no Maybe I'm not understanding the proposed solution:
Is there anything I'm missing in this command |
Maybe setting |
Before 24814bd, LDFLAGS needed to be set empty for me, to override the RPM values. I do suggest dropping the RPMs completely if they do not work for you, simply (?) install R, PROJ and GDAL from source, but use RPMs for GDAL upstream dependencies. Best try to install from github, as LDFLAGS= has been dropped there. |
This worked!! Thanks a lot. I installed PROJ and R from source and gdal from rpm. Then, iInstalling from github worked fine. Thanks! |
For the sake of completeness: I had the same error on F32 and solved it with |
That sounds like the more attractive recipe. Shall I add that to the README.md section? I do indeed believe that for compiling |
I would say yes. Apparently |
Can confirm hriebl's workaround using |
I arrive here via a report by @rsbivand for rgdal in the R-SIG-Fedora mailing list. The issue in this case (as it is now in rgdal) was that |
Thanks -- like that? |
Yes, like that. :) |
The latest sf version does not compile under fedora: configure yields
Using the PIC version of the FLAGS with R Config solves the issue.
See PR: #1368
The text was updated successfully, but these errors were encountered: