🐛 fix: correct timeout duration calculation in repel command #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Fixes unit handling in the repel moderation command so the timeout duration passed to the API is correct.
- Passes duration directly to the timeout API rather than multiplying by an hour constant.
- Keeps return value unchanged.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/commands/moderation/repel.ts
Outdated
Comment on lines
120
to
121
| await target.timeout(duration, 'Repel command executed'); | ||
| return duration; |
There was a problem hiding this comment.
[nitpick] Please document the unit of duration (e.g., milliseconds) in the handleTimeout contract and ensure the return value unit is explicitly stated. Adding a brief JSDoc on the function (or renaming the parameter to durationMs) will prevent future unit confusion.
Copilot uses AI. Check for mistakes.
…period in repel command
wiktoriavh
approved these changes
Oct 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.