Refactoring and bug fixes for osiris_log #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring to better handle cases where previously the `next` offset spec would try to attach to the eof position even though this can vary depending on whether the log is being written to during reader init. This would result in many unexpected_chunk_id exceptions during load. t Also refactoring and simplifying other aspects of reader init to make code clearer and in some cases faster.
kjnilsson
force-pushed
the
osiris-log-init-refactoring
branch
from
a6003d1 to
0ab12d3
Compare
acogoluegnes
added a commit
to rabbitmq/rabbitmq-stream-java-client
that referenced
this pull request
Sep 9, 2021
rabbitmq/osiris#50 should fix the "next" offset problem. References #26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring to better handle cases where previously the
nextoffset specwould try to attach to the eof position even though this can vary depending
on whether the log is being written to during reader init. This would result
in many unexpected_chunk_id exceptions during load.
Also refactoring and simplifying other aspects of reader init to make
code clearer and in some cases faster.