Skip to content

Commit efb414b

Browse files
committed
Revert ConnectionFactory return type in some methods
Some changes from main snuck into 5.x during a merge. This affects 3 methods in ConnectionFactory that used to return void and returned ConnectionFactory because of the unexpected merge. The change is source-compatible but not binary-compatible. It should not affect many users, but we try to stick to backward compatibility so we go back to returning void. References #1810
1 parent 004b9e7 commit efb414b

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

src/main/java/com/rabbitmq/client/ConnectionFactory.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1382,9 +1382,8 @@ public Connection newConnection(
13821382
* @deprecated user {@link #netty()} instead
13831383
*/
13841384
@Deprecated
1385-
public ConnectionFactory setNioParams(NioParams nioParams) {
1385+
public void setNioParams(NioParams nioParams) {
13861386
this.nioParams = nioParams;
1387-
return this;
13881387
}
13891388

13901389
/**
@@ -1415,20 +1414,18 @@ public NioParams getNioParams() {
14151414
* @deprecated Use {@link #netty()} instead
14161415
*/
14171416
@Deprecated
1418-
public ConnectionFactory useNio() {
1417+
public void useNio() {
14191418
this.nio = true;
14201419
this.netty = false;
1421-
return this;
14221420
}
14231421

14241422
/**
14251423
* Use blocking IO for communication with the server. With blocking IO, each connection creates
14261424
* its own thread to read data from the server.
14271425
*/
1428-
public ConnectionFactory useBlockingIo() {
1426+
public void useBlockingIo() {
14291427
this.nio = false;
14301428
this.netty = false;
1431-
return this;
14321429
}
14331430

14341431
/**

0 commit comments

Comments
 (0)