Skip to content

Conversation

@abousselmi
Copy link
Contributor

Dear reviewer,
I added an ID variable to PerfTest.java to identify each running test.
I also modified the System.out to work better when multiple PerfTest threads are running in the same machine.
Best regards,
AB.

@michaelklishin
Copy link
Contributor

Thank you. I am not 100% sure we should ship this in 3.6.x so it will have to wait for 4.0.0 (née 3.7.0).

@michaelklishin michaelklishin added this to the 3.7.0 milestone Aug 23, 2016
@abousselmi
Copy link
Contributor Author

Thank you for your reply. Until then!

@acogoluegnes
Copy link
Contributor

acogoluegnes commented Aug 23, 2016

@abousselmi maybe you could rename showRate to getRate now it returns a String and no longer shows something in the console?

@abousselmi
Copy link
Contributor Author

It's a good idea! Will do it. Thank you.

@acogoluegnes acogoluegnes merged commit a4e9669 into rabbitmq:master Aug 24, 2016
@acogoluegnes acogoluegnes modified the milestones: 3.6.6, 4.0.0 Aug 24, 2016
@abousselmi
Copy link
Contributor Author

@acogoluegnes I added a test id also to the final output messages, whould it be possible to make a new pull request for it ? Thank you.

@michaelklishin
Copy link
Contributor

@abousselmi you can submit a new pull request, sure.

@abousselmi
Copy link
Contributor Author

Thank you for you reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants