Resolve CLI elixirc warnings #10459
Merged
Resolve CLI elixirc warnings #10459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test should fail when `mix compile --warnings-as-errors` gives any warnings.
* Remove unused aliases/imports * Remove or underscore unused bindings * Fix variables that should be atoms (`unavailable` -> `:unavailable`) Also, `Logger.warn/1` has been replaced by `Logger.warning/1`. It should be safe to just replace the call with `Logger.warning/1` since it's been in the standard library since Elixir 1.11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the elixirc warnings in the CLI are benign. There are a few cases where I believe a variable was meant to be an atom instead though, which should change some error-handling behavior slightly.
I've also added a bazel test for running
mix compile --warnings-as-errorsso these can be caught by the CI in the future.