Speed up 'rabbitmqctl stop_app' #11070
Merged
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that `stop_app` would take over 5 seconds on an empty node which is strange. I found this gap in the logs: ``` 2024-04-18 10:49:04.646450+09:00 [info] <0.599.0> Management plugin: to stop collect_statistics. 2024-04-18 10:49:09.647652+09:00 [debug] <0.247.0> Set stop reason to: normal ``` No point waiting for that stats to stop being emitted when we stop the node completely. It was added in 0e640da5 to ensure the stats stop when the management_agent gets disabled
michaelklishin
approved these changes
Apr 24, 2024
Collaborator
michaelklishin
left a comment
michaelklishin
left a comment
There was a problem hiding this comment.
I can confirm that time rabbitmqctl stop_app goes down from 5.4s to 0.4s on this branch.
michaelklishin
added a commit
that referenced
this pull request
Apr 24, 2024
Speed up 'rabbitmqctl stop_app' (backport #11070)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
stop_appwould take over 5 seconds on an empty node which is strange. I found this gap in the logs:No point waiting for that stats to stop being emitted when we stop the node completely. It was added in 0e640da5 to ensure the stats stop when the management_agent gets disabled