rabbit_feature_flags: Accept "+feature1,-feature2" in $RABBITMQ_FEATURE_FLAGS
#12445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
changed the title
$RABBITMQ_FEATURE_FLAGS
dumbbell
force-pushed
the
accept-relative-feature-flags-list-in-RABBITMQ_FEATURE_FLAGS-env
branch
2 times, most recently
from
f4e646f to
2489ae3
Compare
dumbbell
changed the title
$RABBITMQ_FEATURE_FLAGS$RABBITMQ_FEATURE_FLAGS
dumbbell
force-pushed
the
accept-relative-feature-flags-list-in-RABBITMQ_FEATURE_FLAGS-env
branch
from
2489ae3 to
c06fe5b
Compare
…RE_FLAGS
[Why]
Before this patch, the $RABBITMQ_FEATURE_FLAGS environment variable took
an exhaustive list of feature flags to enable. This list overrode the
default of enabling all stable feature flags.
It made it inconvenient when a user wanted to enable an experimental
feature flag like `khepri_db` while still leaving the default behavior.
[How]
$RABBITMQ_FEATURE_FLAGS now acceps the following syntax:
RABBITMQ_FEATURE_FLAGS=+feature1,-feature2
This will start RabbitMQ with all stable feature flags, plus `feature1`,
but without `feature2`.
For users setting `forced_feature_flags_on_init` in the config, the
corresponding syntax is:
{forced_feature_flags_on_init, {rel, [feature1], [feature2]}}
[Why] Its use was removed when the registry was converted from a compiled module to a persistent_term.
dumbbell
force-pushed
the
accept-relative-feature-flags-list-in-RABBITMQ_FEATURE_FLAGS-env
branch
from
c06fe5b to
9b2c6d9
Compare
dumbbell
deleted the
accept-relative-feature-flags-list-in-RABBITMQ_FEATURE_FLAGS-env
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Before this patch, the
$RABBITMQ_FEATURE_FLAGSenvironment variable took an exhaustive list of feature flags to enable. This list overrode the default of enabling all stable feature flags.It made it inconvenient when a user wanted to enable an experimental feature flag like
khepri_dbwhile still leaving the default behavior.How
$RABBITMQ_FEATURE_FLAGSnow acceps the following syntax:This will start RabbitMQ with all stable feature flags, plus
feature1, but withoutfeature2.For users setting
forced_feature_flags_on_initin the config, the corresponding syntax is:{forced_feature_flags_on_init, {rel, [feature1], [feature2]}}While working on
rabbit_env, remove the support for$RABBITMQ_LOG_FF_REGISTRY. Its use was removed when the registry was converted from a compiled module to a persistent_term.