GitHub Actions: Run mixed-version testing against 4.0.3 explicitly #12768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
changed the title
dumbbell
force-pushed
the
test-against-4.0.x-explicitly
branch
from
7546430 to
ce7c91d
Compare
dumbbell
force-pushed
the
test-against-4.0.x-explicitly
branch
from
1276f7e to
dd49b7e
Compare
lhoguin
approved these changes
Nov 21, 2024
... not any release. [Why] Once we release RabbitMQ 4.1.0, it means that the `v4.1.x` branch would be tested against 4.1.x, i.e. itself. Note that we will have to update this pinned version from time to time if needed.
[Why] Using the `fetch-gh-release-asset` action outputs work fine for our official releases, but it does not for our alphas published to `rabbitmq/server-packages` because the filenames use another version compared to the GitHub release. [How] Always derive the version from the archive filename. This is safe regardless of what the GitHub release states.
[Why] Our alpha packages published to `rabbitmq/server-packages` use letters in addition to digits and dots. [How] Accept any string that starts with a digit as the version here. We just enforce the prefix and the filename extension. The digit at the beginning it here to exclude the `rabbitmq-server-generic-unix-latest-toolchain-*.tar.xz` archive.
dumbbell
force-pushed
the
test-against-4.0.x-explicitly
branch
from
c81b148 to
37539d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… not any release.
Why
Once we release RabbitMQ 4.1.0, it means that the
v4.1.xbranch would be tested against 4.1.x, i.e. itself.Note that we will have to update this pinned version from time to time if needed.