rabbitmq_peer_discovery_consul: Set bind_addr to 127.0.0.1 in test config
#12858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Allowing Consul to bind to all interfaces is definitely a better idea. |
dumbbell
force-pushed
the
consul-do-not-set-bind_addr-in-test-config
branch
from
13f8389 to
5ba26fc
Compare
…config [Why] The test configuration was querying a network interface IP address based on its name. However, the name, "eth0", is very specific to Linux. This broke the test on other systems. [How] We still have to set an explicit `bind_addr` because Consul refuses to start if the host has multiple private IPv4 addresses, as it is the case in CI. Therefore, we hard-code 127.0.0.1 as the IPv4 address to use because it has a great chance to exist about anywhere.
[Why] It helps diagnose any startup issues. Typically a problem with the configuration where the log file is not yet created.
dumbbell
force-pushed
the
consul-do-not-set-bind_addr-in-test-config
branch
from
5ba26fc to
b03f0bd
Compare
dumbbell
changed the title
bind_addr in test configbind_addr to 127.0.0.1 in test config
Collaborator
Author
Unfortunately that didn’t work. GitHub Actions hosts have several IPv4 addresses configured and the Consul daemon doesn’t like it. |
Collaborator
|
@dumbbell should we backport this to |
Collaborator
Author
|
I will backport the pull requests in order tomorrow. Thanks! |
dumbbell
added a commit
that referenced
this pull request
Dec 3, 2024
rabbitmq_peer_discovery_consul: Set `bind_addr` to 127.0.0.1 in test config (backport #12858)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The test configuration was querying a network interface IP address based on its name. However, the name, "eth0", is very specific to Linux. This broke the test on other systems.
How
We still have to set an explicit
bind_addrbecause Consul refuses to start if the host has multiple private IPv4 addresses, as it is the case in CI.Therefore, we hard-code 127.0.0.1 as the IPv4 address to use because it has a great chance to exist about anywhere.
V2: We abandon the idea of not setting
bind_addrbecause GitHub Actions default hosts have several private IPv4 addresses configured.