Skip to content

QQ: improve fifo client log message on leader change #13083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2025
+10 −6
Merged

QQ: improve fifo client log message on leader change #13083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions deps/rabbit/src/rabbit_fifo_client.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,20 +644,24 @@ handle_ra_event(_QName, _, {machine, {queue_status, Status}},
%% just set the queue status
{ok, State#state{queue_status = Status}, []};
handle_ra_event(_QName, Leader, {machine, leader_change},
#state{leader = OldLeader} = State0) ->
#state{leader = OldLeader,
pending = Pending} = State0) ->
%% we need to update leader
%% and resend any pending commands
rabbit_log:debug("~ts: Detected QQ leader change from ~w to ~w",
[?MODULE, OldLeader, Leader]),
rabbit_log:debug("~ts: Detected QQ leader change from ~w to ~w, "
"resending ~b pending commands",
[?MODULE, OldLeader, Leader, maps:size(Pending)]),
State = resend_all_pending(State0#state{leader = Leader}),
{ok, State, []};
handle_ra_event(_QName, _From, {rejected, {not_leader, Leader, _Seq}},
#state{leader = Leader} = State) ->
{ok, State, []};
handle_ra_event(_QName, _From, {rejected, {not_leader, Leader, _Seq}},
#state{leader = OldLeader} = State0) ->
rabbit_log:debug("~ts: Detected QQ leader change (rejection) from ~w to ~w",
[?MODULE, OldLeader, Leader]),
#state{leader = OldLeader,
pending = Pending} = State0) ->
rabbit_log:debug("~ts: Detected QQ leader change (rejection) from ~w to ~w, "
"resending ~b pending commands",
[?MODULE, OldLeader, Leader, maps:size(Pending)]),
State = resend_all_pending(State0#state{leader = Leader}),
{ok, cancel_timer(State), []};
handle_ra_event(_QName, _From, {rejected, {not_leader, _UndefinedMaybe, _Seq}}, State0) ->
Expand Down
Loading