Skip to content

Remove log level tests (backport #13723) (backport #13730) #13731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

Remove log level tests (backport #13723) (backport #13730) #13731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 1 addition & 37 deletions deps/rabbit/src/rabbit_prelaunch_logging.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,12 +527,7 @@ configure_logger(Context) ->
%% We can now install the new handlers. The function takes care of
%% removing previously configured handlers (after installing the new
%% ones to ensure we don't loose a message).
ok = install_handlers(Handlers),

%% Let's log a message per log level (if debug logging is enabled). This
%% is handy if the user wants to verify the configuration is what he
%% expects.
ok = maybe_log_test_messages(LogConfig3).
ok = install_handlers(Handlers).

-spec get_log_configuration_from_app_env() -> log_config().

Expand Down Expand Up @@ -1690,34 +1685,3 @@ get_less_severe_level(LevelA, LevelB) ->
lt -> LevelA;
_ -> LevelB
end.

-spec maybe_log_test_messages(log_config()) -> ok.

maybe_log_test_messages(
#{per_category := #{prelaunch := #{level := debug}}}) ->
log_test_messages();
maybe_log_test_messages(
#{global := #{level := debug}}) ->
log_test_messages();
maybe_log_test_messages(_) ->
ok.

-spec log_test_messages() -> ok.

log_test_messages() ->
?LOG_DEBUG("Logging: testing debug log level",
#{domain => ?RMQLOG_DOMAIN_PRELAUNCH}),
?LOG_INFO("Logging: testing info log level",
#{domain => ?RMQLOG_DOMAIN_PRELAUNCH}),
?LOG_NOTICE("Logging: testing notice log level",
#{domain => ?RMQLOG_DOMAIN_PRELAUNCH}),
?LOG_WARNING("Logging: testing warning log level",
#{domain => ?RMQLOG_DOMAIN_PRELAUNCH}),
?LOG_ERROR("Logging: testing error log level",
#{domain => ?RMQLOG_DOMAIN_PRELAUNCH}),
?LOG_CRITICAL("Logging: testing critical log level",
#{domain => ?RMQLOG_DOMAIN_PRELAUNCH}),
?LOG_ALERT("Logging: testing alert log level",
#{domain => ?RMQLOG_DOMAIN_PRELAUNCH}),
?LOG_EMERGENCY("Logging: testing emergency log level",
#{domain => ?RMQLOG_DOMAIN_PRELAUNCH}).
Loading