Avoid list allocation #14088
Merged
Avoid list allocation #14088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is simmilar to #14056. The performance benefit is probably negligbile though since this is called only after each batch of Ra commands. Nevertheless, it's unnecessary to allocate a list with 3 elements and therefore 6 words on the heap, so let's optimise it.
michaelklishin
approved these changes
Jun 17, 2025
michaelklishin
added a commit
that referenced
this pull request
Jun 17, 2025
Avoid list allocation (backport #14088)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #14056. The performance benefit is probably negligbile though since this is called only after each batch of Ra commands.
Nevertheless, it's unnecessary to allocate a list with 3 elements and therefore 6 words on the heap, so let's optimise it.