Skip to content

Conversation

@ikavgo
Copy link
Contributor

@ikavgo ikavgo commented Jun 27, 2025

Without this change delete/3 callback for custom exchange type wasn't called and warning about invalid exchange type appeared in the logs. What is interesting - that exchange module was logged as an invalid type for previously declared exchange of that module ¯_(ツ)_/¯.

Without this change delete/3 callback for custom exchange type wasn't called and warning about invalid exchange type appeared in the logs.
What is interesting that exchange module was logged as an invalid type for previously declared exchange of that module ¯\_(ツ)_/¯.
@ikavgo ikavgo marked this pull request as draft June 27, 2025 08:59
@ikavgo ikavgo changed the title use registry:lookup_type_module inside exchange:type_to_module Use registry:lookup_type_module inside exchange:type_to_module Jun 27, 2025
@ikavgo ikavgo marked this pull request as ready for review June 27, 2025 09:24
@ikavgo ikavgo requested a review from michaelklishin June 27, 2025 09:24
@ikavgo ikavgo merged commit 24397a7 into main Jun 27, 2025
565 of 567 checks passed
@ikavgo ikavgo deleted the ik-exchange-module-lookup-test branch June 27, 2025 09:58
@michaelklishin michaelklishin added this to the 4.2.0 milestone Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants