Skip to content

Conversation

@michaelklishin
Copy link
Collaborator

Proposed Changes

This slightly improves error handling improvements in rabbit_epmd_monitor:check_epmd/1.

To produce less noise and more informative messages.
This also introduces a function that allows for manual
check triggering.

Types of Changes

  • Bug fix (non-breaking change which fixes issue Handle more errors in rabbit_epmd_monitor #2130)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

Closes #2130.

To produce less noise and more informative messages.
This also introduces a function that allows for manual
check triggering.

Closes #2130.
Copy link
Collaborator

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Commit ef580fb changes the output from this:

2019-10-03 09:00:02.487 [debug] <0.528.0> Asked to [re-]register this node (rabbit@"MESSIAEN") with epmd...
(rabbit@MESSIAEN)2> 2019-10-03 09:00:02.634 [debug] <0.528.0> [Re-]registered this node (rabbit@"MESSIAEN") with epmd at port 25672

to this (no extra double-quotes):

2019-10-03 09:01:36.709 [debug] <0.407.0> Asked to [re-]register this node (rabbit@MESSIAEN) with epmd...
(rabbit@MESSIAEN)2> 2019-10-03 09:01:36.860 [debug] <0.407.0> [Re-]registered this node (rabbit@MESSIAEN) with epmd at port 25672

@michaelklishin michaelklishin merged commit f201e56 into master Oct 3, 2019
@michaelklishin michaelklishin deleted the rabbitmq-server-2130 branch October 3, 2019 16:05
lukebakken pushed a commit that referenced this pull request Oct 3, 2019
Error handling improvements in rabbit_epmd_monitor:check_epmd/1

(cherry picked from commit f201e56)
@lukebakken
Copy link
Collaborator

Backported to v3.8.x

lukebakken pushed a commit that referenced this pull request Oct 3, 2019
Error handling improvements in rabbit_epmd_monitor:check_epmd/1

(cherry picked from commit f201e56)
@lukebakken
Copy link
Collaborator

Backported to v3.7.x

@lukebakken lukebakken added this to the 3.7.20 milestone Oct 3, 2019
@michaelklishin michaelklishin removed this from the 3.7.20 milestone Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle more errors in rabbit_epmd_monitor

4 participants