Skip DNS lookup when AddressResolver is configured
#445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an `AddressResolver` is configured, the client still attempts DNS lookups for advertised broker hostnames from metadata responses. This causes 10-second timeouts per connection before falling back to the resolver. This change introduces `BrokerLeaderWithResolver` and `BrokerForConsumerWithResolver` methods that check for an `AddressResolver` before attempting DNS lookup. When a resolver exists, these methods use the resolver's host and port directly, bypassing DNS resolution entirely. The original `BrokerLeader` and `BrokerForConsumer` methods remain unchanged for backward compatibility and delegate to the new methods with a `nil` resolver parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an
AddressResolveris configured, the client still attempts DNS lookups for advertised broker hostnames from metadata responses. This causes 10-second timeouts per connection before falling back to the resolver.This change introduces
BrokerLeaderWithResolverandBrokerForConsumerWithResolvermethods that check for anAddressResolverbefore attempting DNS lookup. When a resolver exists, these methods use the resolver's host and port directly, bypassing DNS resolution entirely.The original
BrokerLeaderandBrokerForConsumermethods remain unchanged for backward compatibility and delegate to the new methods with anilresolver parameter.