Fix Ginkgo test structure in environment_test.go
#448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seven `Describe` blocks in `environment_test.go` incorrectly contain test code directly in the `Describe` block body instead of inside `It` blocks. Ginkgo requires all assertions and test setup to be inside leaf nodes (`It`, `BeforeEach`, `AfterEach`, etc.), not in container nodes. This causes panics during test tree construction when the test framework is not fully initialized. This change wraps all test code in the following `Describe` blocks with appropriate `It` blocks: - "TCP Parameters" - "Environment Validations" - "Validation Query Offset/Sequence" - "Stream Existing/Meta data" - "Address Resolver" - "Query Offset should return the value from Store Offset" - "QueryOffset DeclareStream StoreOffset should reconnect the locator" All tests now pass successfully with proper Ginkgo structure.
lukebakken
force-pushed
the
lukebakken/ginkgo-test-fixes
branch
from
2203642 to
1e6b6fe
Compare
Gsantomaggio
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seven
Describeblocks inenvironment_test.goincorrectly contain test code directly in theDescribeblock body instead of insideItblocks. Ginkgo requires all assertions and test setup to be inside leaf nodes (It,BeforeEach,AfterEach, etc.), not in container nodes. This causes panics during test tree construction when the test framework is not fully initialized.This change wraps all test code in the following
Describeblocks withappropriate
Itblocks:All tests now pass successfully with proper Ginkgo structure.