tls support improvements, added trust to hostname and ca certificate #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
+ Coverage 87.22% 87.35% +0.13%
==========================================
Files 68 68
Lines 5517 5503 -14
==========================================
- Hits 4812 4807 -5
+ Misses 705 696 -9
☔ View full report in Codecov by Sentry. |
DanielePalaia
force-pushed
the
implement_trust_certificate
branch
from
3a5319f to
78335a6
Compare
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
DanielePalaia
force-pushed
the
implement_trust_certificate
branch
11 times, most recently
from
cac5b05 to
e814e0d
Compare
DanielePalaia
force-pushed
the
implement_trust_certificate
branch
2 times, most recently
from
21b9f43 to
685e21d
Compare
DanielePalaia
force-pushed
the
implement_trust_certificate
branch
from
685e21d to
69e2bf5
Compare
Gsantomaggio
approved these changes
Aug 1, 2023
wolf4ood
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces tokio-native-tls with tokio::rusttls.
This was due because with tokio-native-tls certificate authentication wasn't working properly.
Comparing to previous release it also supports now certificate authentication and it adds an example