Skip to content

Correct the contents of 'registered' key in .app files #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HoloRin merged 1 commit into from
May 2, 2023
Merged

Correct the contents of 'registered' key in .app files #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions private/app_file.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,16 @@ def _impl(ctx):
src = ""

app_module = ctx.attr.app_module if ctx.attr.app_module != "" else ctx.attr.app_name + "_app"
if len([m for m in ctx.files.modules if m.basename == app_module + ".beam"]) != 1:
app_module = ""

modules = "[" + ",".join([_module_name(m) for m in ctx.files.modules]) + "]"

if len(ctx.attr.app_registered) > 0:
if len([m for m in ctx.files.modules if m.basename == app_module + ".beam"]) > 0:
registered_list = "[" + ",".join([ctx.attr.app_name + "_sup"] + ctx.attr.app_registered) + "]"
else:
app_module = ""
if len(ctx.attr.app_registered) > 0:
fail(app_module, "is not present, but app_registered was provided.")
registered_list = ""

modules = "[" + ",".join([_module_name(m) for m in ctx.files.modules]) + "]"

applications_list = ""
if src == "" or len(ctx.attr.extra_apps) > 0 or len(ctx.attr.deps) > 0:
applications = ["kernel", "stdlib"] + ctx.attr.extra_apps
Expand All @@ -52,7 +52,7 @@ def _impl(ctx):
if [ -n "{src}" ]; then
cp {src} {out}
else
echo "{{application,'{name}',[{{registered, ['{name}_sup']}},{{env, []}}]}}." > {out}
echo "{{application,'{name}',[{{registered, []}},{{env, []}}]}}." > {out}
fi

if [ -n '{description}' ]; then
Expand Down