Adding playbook to install and configure k8s nodes #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we set cluster_name per inventory, setting it in group vars cerates a preference issue, overriding the inventory hostvar
cloudnull
reviewed
Feb 13, 2024
cloudnull
requested changes
Feb 13, 2024
Contributor
cloudnull
left a comment
cloudnull
left a comment
There was a problem hiding this comment.
this is looking great. I have a bunch of little nits, but looks great.
BjoernT
force-pushed
the
main
branch
3 times, most recently
from
39dfbe2 to
bd7f3b1
Compare
BjoernT
force-pushed
the
main
branch
2 times, most recently
from
6ee6e32 to
4ed7372
Compare
- Add k8s_install role to install, upgrade and configure k8s nodes post install, such as labling - Add scaffolding to support future k8s installer
cloudnull
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add k8s_install role to install, upgrade and configure k8s nodes post
install, such as labling
Add scaffolding to support future k8s installer